Thread (14 messages) 14 messages, 2 authors, 2022-08-18

Re: [PATCH linux-phy v2 1/4] string.h: Add str_has_proper_prefix()

From: Andy Shevchenko <hidden>
Date: 2022-08-18 19:11:39
Also in: lkml

On Wed, Aug 17, 2022 at 11:06 PM Marek Behún [off-list ref] wrote:
Add str_has_proper_prefix(), similar to str_has_prefix(), but requires
that the prefix is proper: the string itself must be longer than the
prefix.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
Andy, Kees, could you ack this if it is ok?
Seems to me there are too many strlen():s. One is hidden in strncmp().

Besides not the good naming (what 'proper' means), the entire function
is not needed. You may simply call

  str_has_prefix() && p[len] != '\0';

Correct?

-- 
With Best Regards,
Andy Shevchenko

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help