Re: ARMADA espressobin SATA drive detection failure
From: Shinichiro Kawasaki <hidden>
Date: 2022-08-13 11:53:55
On Aug 13, 2022 / 11:32, Pali Rohár wrote:
On Saturday 13 August 2022 01:35:35 Shinichiro Kawasaki wrote:
[...]
quoted hunk ↗ jump to hunk
Ok, thanks for testing. It looks like that reset code has some issues. Could you please test this change?@@ -1393,7 +1436,8 @@ static int mvebu_a3700_comphy_probe(struct platform_device *pdev) * To avoid relying on the bootloader/firmware configuration, * power off all comphys. */ - mvebu_a3700_comphy_reset(phy); +// mvebu_a3700_comphy_reset(phy); + mvebu_a3700_comphy_power_off(phy); lane->needs_reset = false; }It should replace reset code by power off at beginning / probe time.
This change also avoided the "ata1: SATA link down (SStatus 0 SControl 300)" message, and my SSD was detected as /dev/sda. Good symptoms for me. FYI, I attach the console log with this change. (This time, following messages were printed. Not sure if they are important or not.) [ 2.937376] mvebu-a3700-comphy d0018300.phy: invalid COMPHY mode [ 2.943581] mvebu-a3700-comphy d0018300.phy: invalid COMPHY mode [ 2.949679] mvebu-a3700-comphy d0018300.phy: invalid COMPHY mode -- Shin'ichiro Kawasaki
Attachments
- console_log_v5.18.16_power_off_patch.log [text/plain] 38045 bytes · preview
- (unnamed) [text/plain] 112 bytes · preview