Thread (18 messages) 18 messages, 4 authors, 2022-07-26

RE: [PATCH net-next v3 46/47] arm64: dts: ls1046ardb: Add serdes bindings

From: Camelia Alexandra Groza <hidden>
Date: 2022-07-26 11:35:25
Also in: linux-arm-kernel, linux-devicetree, lkml, netdev 

-----Original Message-----
From: Sean Anderson <redacted>
Sent: Monday, July 25, 2022 23:02
To: Camelia Alexandra Groza <redacted>; David S . Miller
[off-list ref]; Jakub Kicinski [off-list ref]; Madalin Bucur
[off-list ref]; netdev@vger.kernel.org
Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
[off-list ref]; linux-arm-kernel@lists.infradead.org; Russell
King [off-list ref]; linux-kernel@vger.kernel.org; Kishon Vijay
Abraham I [off-list ref]; Krzysztof Kozlowski
[off-list ref]; Leo Li [off-list ref]; Rob
Herring [off-list ref]; Shawn Guo [off-list ref]; Vinod
Koul [off-list ref]; devicetree@vger.kernel.org; linux-
phy@lists.infradead.org
Subject: Re: [PATCH net-next v3 46/47] arm64: dts: ls1046ardb: Add serdes
bindings



On 7/22/22 8:41 AM, Camelia Alexandra Groza wrote:
quoted
quoted
-----Original Message-----
From: Sean Anderson <redacted>
Sent: Thursday, July 21, 2022 18:41
To: Camelia Alexandra Groza <redacted>; David S . Miller
[off-list ref]; Jakub Kicinski [off-list ref]; Madalin
Bucur
quoted
quoted
[off-list ref]; netdev@vger.kernel.org
Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
[off-list ref]; linux-arm-kernel@lists.infradead.org; Russell
King [off-list ref]; linux-kernel@vger.kernel.org; Kishon Vijay
Abraham I [off-list ref]; Krzysztof Kozlowski
[off-list ref]; Leo Li [off-list ref]; Rob
Herring [off-list ref]; Shawn Guo [off-list ref];
Vinod
quoted
quoted
Koul [off-list ref]; devicetree@vger.kernel.org; linux-
phy@lists.infradead.org
Subject: Re: [PATCH net-next v3 46/47] arm64: dts: ls1046ardb: Add
serdes
quoted
quoted
bindings



On 7/21/22 10:20 AM, Camelia Alexandra Groza wrote:
quoted
quoted
-----Original Message-----
From: Sean Anderson <redacted>
Sent: Saturday, July 16, 2022 1:00
To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
[off-list ref]; Madalin Bucur [off-list ref];
netdev@vger.kernel.org
Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
[off-list ref]; linux-arm-kernel@lists.infradead.org;
Russell
quoted
quoted
quoted
quoted
King [off-list ref]; linux-kernel@vger.kernel.org; Sean
Anderson
quoted
quoted
[off-list ref]; Kishon Vijay Abraham I
[off-list ref];
quoted
quoted
quoted
quoted
Krzysztof Kozlowski [off-list ref]; Leo Li
[off-list ref]; Rob Herring [off-list ref]; Shawn
Guo
quoted
quoted
quoted
quoted
[off-list ref]; Vinod Koul [off-list ref];
devicetree@vger.kernel.org; linux-phy@lists.infradead.org
Subject: [PATCH net-next v3 46/47] arm64: dts: ls1046ardb: Add serdes
bindings

This adds appropriate bindings for the macs which use the SerDes. The
156.25MHz fixed clock is a crystal. The 100MHz clocks (there are
actually 3) come from a Renesas 6V49205B at address 69 on i2c0. There
is
quoted
quoted
quoted
quoted
no driver for this device (and as far as I know all you can do with the
100MHz clocks is gate them), so I have chosen to model it as a single
fixed clock.

Note: the SerDes1 lane numbering for the LS1046A is *reversed*.
This means that Lane A (what the driver thinks is lane 0) uses pins
SD1_TX3_P/N.

Because this will break ethernet if the serdes is not enabled, enable
the serdes driver by default on Layerscape.

Signed-off-by: Sean Anderson <redacted>
---
Please let me know if there is a better/more specific config I can use
here.

(no changes since v1)
My LS1046ARDB hangs at boot with this patch right after the second
SerDes
quoted
quoted
is probed,
quoted
right before the point where the PCI host bridge is registered. I can get
around this
quoted
either by disabling the second SerDes node from the device tree, or
disabling
quoted
CONFIG_PCI_LAYERSCAPE at build.

I haven't debugged it more but there seems to be an issue here.
Hm. Do you have anything plugged into the PCIe/SATA slots? I haven't
been
quoted
quoted
testing with
anything there. For now, it may be better to just leave it disabled.

--Sean
Yes, I have an Intel e1000 card plugged in.

Camelia
Can you try the following patch? I was able to boot with PCI with it applied.
Works for me as well. The board boots fine and the PCI card is functional. Thanks.
quoted hunk ↗ jump to hunk
From 71f4136f1bdda89009936a9c24561b60e0554859 Mon Sep 17 00:00:00
2001
From: Sean Anderson <redacted>
Date: Mon, 25 Jul 2022 16:01:16 -0400
Subject: [PATCH] arm64: dts: ls1046a: Fix missing PCIe lane

Signed-off-by: Sean Anderson <redacted>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 0b3765cad383..3841ba274782 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -532,7 +532,7 @@ pcie-0 {
 					/* PCIe.1 x1 */
 					cfg-1 {
 						fsl,cfg = <0x1>;
-						fsl,first-lane = <1>;
+						fsl,first-lane = <0>;
 					};

 					/* PCIe.1 x4 */
@@ -543,6 +543,14 @@ cfg-3 {
 					};
 				};

+				/* PCIe.2 x1 */
+				pcie-1 {
+					fsl,index = <1>;
+					fsl,proto = "pcie";
+					fsl,cfg = <0x1>;
+					fsl,first-lane = <1>;
+				};
+
 				pcie-2 {
 					fsl,index = <2>;
 					fsl,proto = "pcie";
--
2.35.1.1320.gc452695387.dirty
-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help