Re: [PATCH v2 03/30] dt-bindings: phy: qcom,qmp: drop redundant descriptions

On 14/07/2022 12:00, Johan Hovold wrote:

On Thu, Jul 14, 2022 at 11:07:21AM +0200, Krzysztof Kozlowski wrote:

quoted

On 07/07/2022 15:46, Johan Hovold wrote:

quoted

Drop the redundant supply and clock descriptions which did not add much
information beyond what can be inferred from the corresponding resource
names.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

(...)

quoted

             - const: ref
             - const: refgen
         resets:
-          items:
-            - description: reset of phy block.
+          maxItems: 1
         reset-names:
           items:
             - const: phy

@@ -376,11 +334,7 @@ allOf:
     then:
       properties:
         clocks:
-          items:
-            - description: Phy aux clock.
-            - description: 19.2 MHz ref clk source.
-            - description: 19.2 MHz ref clk.

Here and in other places - I think you loose information, because the
frequency is not mentioned in clock name.

Right, but it is also arguable redundant information for the binding
(similar for the vdda-pll voltage).

True.

I can add a comment after the name if you prefer that?

Ah, skip it.


Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy