Re: [PATCH v3 3/5] phy: samsung: ufs: constify samsung_ufs_phy_cfg
flat view
From: Krzysztof Kozlowski <hidden>
Date: 2022-06-05 16:10:00
Also in:
linux-arm-kernel, linux-devicetree, linux-samsung-soc
On 03/06/2022 04:04, Chanho Park wrote:
quoted hunk ↗ jump to hunk
Put const qualifier of samsung_ufs_phy_cfg pointer because they will not be changed from drvdata. Signed-off-by: Chanho Park <redacted> --- drivers/phy/samsung/phy-samsung-ufs.c | 4 ++-- drivers/phy/samsung/phy-samsung-ufs.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c index ed272631e8aa..e1e26da27245 100644 --- a/drivers/phy/samsung/phy-samsung-ufs.c +++ b/drivers/phy/samsung/phy-samsung-ufs.c@@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct phy *phy) static int samsung_ufs_phy_calibrate(struct phy *phy) { struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfgs; + const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfgs; const struct samsung_ufs_phy_cfg *cfg; int err = 0; int i;@@ -327,7 +327,7 @@ static int samsung_ufs_phy_probe(struct platform_device *pdev) drvdata = match->data; phy->dev = dev; phy->drvdata = drvdata; - phy->cfgs = (struct samsung_ufs_phy_cfg **)drvdata->cfgs; + phy->cfgs = drvdata->cfgs; phy->isol = &drvdata->isol; phy->lane_cnt = PHY_DEF_LANE_CNT;diff --git a/drivers/phy/samsung/phy-samsung-ufs.h b/drivers/phy/samsung/phy-samsung-ufs.h index 1788b356cf56..101497698f23 100644 --- a/drivers/phy/samsung/phy-samsung-ufs.h +++ b/drivers/phy/samsung/phy-samsung-ufs.h@@ -121,7 +121,7 @@ struct samsung_ufs_phy { struct clk *rx0_symbol_clk; struct clk *rx1_symbol_clk; const struct samsung_ufs_phy_drvdata *drvdata; - struct samsung_ufs_phy_cfg **cfgs; + const struct samsung_ufs_phy_cfg **cfgs;
I still think this should be array of const pointers to const data, so: const struct samsung_ufs_phy_cfg * const *cfgs; I proposed this in last email. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy