Re: [PATCH] dt-bindings: phy: convert Qualcomm USB HS phy to yaml
From: Bjorn Andersson <hidden>
Date: 2021-12-29 15:33:08
Also in:
linux-arm-msm, linux-devicetree, lkml
On Fri 24 Dec 09:02 PST 2021, David Heidelberg wrote:
Conversion of Qualcomm USB HS phy documentation to yaml. Signed-off-by: David Heidelberg <david@ixit.cz>
Very nice to see your efforts in this area David! Just some minor nits below. [..]
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml new file mode 100644 index 000000000000..202c42754188 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml@@ -0,0 +1,86 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/qcom,usb-hs-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm's USB HS PHY binding description + +maintainers: + - Bjorn Andersson <bjorn.andersson@linaro.org> + +properties: + compatible: + items: + - enum: + - qcom,usb-hs-phy-apq8064 + - qcom,usb-hs-phy-msm8916 + - qcom,usb-hs-phy-msm8974 + - const: qcom,usb-hs-phy + + clocks: true + + clock-names: + oneOf: + - items: + - const: ref + - const: sleep + - items: + - const: sleep + - const: ref
Can't we just pick one of them?
+ + resets: true + + reset-names: + oneOf: + - items: + - const: por + - items: + - const: phy + - const: por
How about doing the: items: - const: por - const: phy minItems: 1
+ + v1p8-supply: true + + v3p3-supply: true + + extcon: true + + "#phy-cells": + const: 0 + + qcom,init-seq: + $ref: /schemas/types.yaml#/definitions/uint8-array
It's better to use the uint8-matrix, as that allows you to describe the value pairs as well. See e.g. st,adc-diff-channels in iio/adc/st,stm32-adc.yaml as an example.
+ description: |
I think you can omit the '|'. Regards, Bjorn
+ Should contain a sequence of ULPI address and value pairs to
+ program into the ULPI_EXT_VENDOR_SPECIFIC area. This is related
+ to Device Mode Eye Diagram test. The addresses are offsets
+ from the ULPI_EXT_VENDOR_SPECIFIC address, for example,
+ <0x1 0x53> would mean "write the value 0x53 to address 0x81".
+
+required:
+ - clocks
+ - clock-names
+ - resets
+ - reset-names
+ - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ otg: usb-controller {
+ ulpi {
+ phy {
+ compatible = "qcom,usb-hs-phy-msm8974", "qcom,usb-hs-phy";
+ #phy-cells = <0>;
+ clocks = <&clk 0>, <&clk 258>;
+ clock-names = "ref", "sleep";
+ resets = <&gcc 10>, <&otg 0>;
+ reset-names = "phy", "por";
+ v3p3-supply = <&pm8941_l24>;
+ v1p8-supply = <&pm8941_l6>;
+ extcon = <&smbb>;
+ qcom,init-seq = /bits/ 8 <0x1 0x63>;
+ };
+ };
+ };
--
2.34.1-- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy