Re: [PATCH phy 2/6] phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation
From: Marek Behún <kabel@kernel.org>
Date: 2021-12-03 20:58:48
From: Marek Behún <kabel@kernel.org>
Date: 2021-12-03 20:58:48
On Tue, 23 Nov 2021 12:56:24 +0530 Vinod Koul [off-list ref] wrote:
quoted
+#define COMPHY_SYNC_MASK_GEN_REG 0x25 +#define PHY_GEN_MAX_OFFSET 10 +#define PHY_GEN_MAX_MASK (3 << PHY_GEN_MAX_OFFSET)Pls use GENMASK()
Dear Vinor, Pali, I have refactored this driver thoroughly to kernel standards (without functional changes) and fixed a lot of register name definitions (they didn't align with Functional Specification). (I have also prepared this fixes for TF-A, but will need to rebase them.) I have also applied one functional change to fix a bug I found, but still need to fix another bug. Hopefully I will have a solution tomorrow or on Sunday. Marek -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy