Thread (30 messages) 30 messages, 6 authors, 2021-09-23

Re: [RFC PATCH net-next 05/12] reset: lan966x: Add switch reset driver

From: Horatiu Vultur <horatiu.vultur@microchip.com>
Date: 2021-09-22 09:58:32
Also in: linux-devicetree, linux-pm, lkml, netdev

The 09/20/2021 14:11, Andrew Lunn wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Mon, Sep 20, 2021 at 11:52:11AM +0200, Horatiu Vultur wrote:
quoted
The lan966x switch SoC has a number of components that can be reset
indiviually, but at least the switch core needs to be in a well defined
state at power on, when any of the lan966x drivers starts to access the
switch core, this reset driver is available.

The reset driver is loaded early via the postcore_initcall interface, and
will then be available for the other lan966x drivers (SGPIO, SwitchDev etc)
that are loaded next, and the first of them to be loaded can perform the
one-time switch core reset that is needed.
A lot of this looks very similar to
reset-microchip-sparx5.c. PROTECT_REG is 0x88 rather than 0x84, but
actually using the value is the same. SOFT_RESET_REG is identical.  So
rather than adding a new driver, maybe you can generalize
reset-microchip-sparx5.c, and add a second compatible string?
You are right, they look similar.
I will try to add a new compatible string.
        Andrew
-- 
/Horatiu

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help