Re: [PATCH v8 03/13] phy: tegra: xusb: Move usb3 port init for Tegra210
From: Vinod Koul <vkoul@kernel.org>
Date: 2021-03-30 14:13:49
Also in:
linux-tegra, linux-usb
Hi Thierry, On 25-03-21, 17:40, Thierry Reding wrote:
+static struct tegra_xusb_usb3_port *
+tegra210_lane_to_usb3_port(struct tegra_xusb_lane *lane)
+{
+ int port;
+
+ if (!lane || !lane->pad || !lane->pad->padctl)
+ return NULL;This looks problematic to me, so if lane is NULL, it will still go ahead and check lane->pad which would result in NULL pointer dereference. -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy