Re: [PATCH v5 (RESEND) 1/7] phy: phy-hi3670-usb3: move driver from staging into phy
flat view
From: Vinod Koul <vkoul@kernel.org>
Date: 2021-03-31 12:47:11
Also in:
linux-devicetree, linux-staging, lkml
On 25-03-21, 19:05, Mauro Carvalho Chehab wrote:
The phy USB3 driver for Hisilicon 970 (hi3670) is ready for mainstream. Mode it from staging into the main driver's phy/ directory.
Overall lgtm, some nits below. With those fixed: Acked-By: Vinod Koul <vkoul@kernel.org>
quoted hunk ↗ jump to hunk
+static int hi3670_phy_cr_clk(struct regmap *usb31misc) +{ + int ret; + + /* Clock up */ + ret = regmap_update_bits(usb31misc, USB_MISC_CFG54, + CFG54_USB31PHY_CR_CLK, CFG54_USB31PHY_CR_CLK); + if (ret) + return ret; + + /* Clock down */ + ret = regmap_update_bits(usb31misc, USB_MISC_CFG54, + CFG54_USB31PHY_CR_CLK, 0); + + return ret;
return regmap_update_bits() ? (i see few more in driver like this, pls change others as well)
quoted hunk ↗ jump to hunk
+static int hi3670_phy_cr_read(struct regmap *usb31misc, u32 addr, u32 *val) +{ + int reg; + int i; + int ret;
all these could be in a single line -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy