Thread (3 messages) 3 messages, 3 authors, 2021-03-15

Re: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()

From: Paul Cercueil <paul@crapouillou.net>
Date: 2021-03-07 15:56:14
Also in: kernel-janitors, lkml


Le ven. 5 mars 2021 à 3:49, 'Wei Yongjun [off-list ref] a 
écrit :
From: Wei Yongjun <redacted>

Fix the return value check typo which testing the wrong variable
in ingenic_usb_phy_probe().

Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic 
PHY framework.")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Wei Yongjun <redacted>
Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul
quoted hunk ↗ jump to hunk
---
 drivers/phy/ingenic/phy-ingenic-usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/ingenic/phy-ingenic-usb.c 
b/drivers/phy/ingenic/phy-ingenic-usb.c
index ea127b177f46..28c28d816484 100644
--- a/drivers/phy/ingenic/phy-ingenic-usb.c
+++ b/drivers/phy/ingenic/phy-ingenic-usb.c
@@ -352,8 +352,8 @@ static int ingenic_usb_phy_probe(struct 
platform_device *pdev)
 	}

 	priv->phy = devm_phy_create(dev, NULL, &ingenic_usb_phy_ops);
-	if (IS_ERR(priv))
-		return PTR_ERR(priv);
+	if (IS_ERR(priv->phy))
+		return PTR_ERR(priv->phy);

 	phy_set_drvdata(priv->phy, priv);


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help