Re: [PATCH] kernel: move from strlcpy with unused retval to strscpy
From: Petr Mladek <pmladek@suse.com>
Date: 2022-08-25 09:28:09
Also in:
bpf, cgroups, lkml
On Thu 2022-08-18 23:02:01, Wolfram Sang wrote:
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ (local) Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- kernel/acct.c | 2 +- kernel/bpf/preload/bpf_preload_kern.c | 4 ++-- kernel/cgroup/cgroup-v1.c | 4 ++-- kernel/events/core.c | 6 +++--- kernel/kallsyms.c | 4 ++-- kernel/params.c | 2 +- kernel/printk/printk.c | 2 +- kernel/relay.c | 4 ++-- kernel/time/clocksource.c | 2 +- kernel/trace/ftrace.c | 18 +++++++++--------- kernel/trace/trace.c | 8 ++++---- kernel/trace/trace_events.c | 2 +- kernel/trace/trace_events_inject.c | 4 ++-- kernel/trace/trace_kprobe.c | 2 +- kernel/trace/trace_probe.c | 2 +- 15 files changed, 33 insertions(+), 33 deletions(-)
This fixes only small part of the kernel code. It would make sense to do a tree-wide change using a script. Would you mind to create one and send it to Linus? You might want to use Coccinelle if a simple sed/awk gets too complicated. See https://www.kernel.org/doc/html/v4.15/dev-tools/coccinelle.html Best Regards, Petr