Re: [PATCH -mm v2 2/3] cn_proc: replaced old hard-coded 16 with TASK_COMM_LEN_16
From: Yafang Shao <hidden>
Date: 2021-12-12 16:26:45
Also in:
bpf, linux-fsdevel, linux-mm, lkml
On Sun, Dec 12, 2021 at 2:10 PM Michal Miroslaw [off-list ref] wrote:
On Sat, Dec 11, 2021 at 06:39:48AM +0000, Yafang Shao wrote:quoted
This TASK_COMM_LEN_16 has the same meaning with the macro defined in linux/sched.h, but we can't include linux/sched.h in a UAPI header, so we should specifically define it in the cn_proc.h.[...]quoted
index db210625cee8..6dcccaed383f 100644--- a/include/uapi/linux/cn_proc.h +++ b/include/uapi/linux/cn_proc.h@@ -21,6 +21,8 @@ #include <linux/types.h> +#define TASK_COMM_LEN_16 16Hi, Since this is added to UAPI header, maybe you could make it a single instance also used elsewhere? Even though this is constant and not going to change I don't really like multiplying the sources of truth.
Hmm, what about defining it in include/uapi/linux/sched.h ? Then include "sched.h" in cn_proc.h And we also define it in tools/include/uapi/linux/sched.h for the usage in tools. -- Thanks Yafang