Re: [PATCH] perf dlfilter: Drop unused variable
From: German Gomez <hidden>
Date: 2021-12-08 10:44:17
Also in:
lkml
On 23/11/2021 21:18, Salvatore Bonaccorso wrote:
Compiling tools/perf/dlfilters/dlfilter-test-api-v0.c result in: checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’: dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable] 311 | struct filter_data *d = data; |
Did you get this warning when issuing "make"? From my side, it generated this gcc command so I didn't get it (make DEBUG=1): gcc -c -Iinclude -o dlfilters/dlfilter-test-api-v0.o -fpic dlfilters/dlfilter-test-api-v0.c Reviewed-by: German Gomez <redacted> Thanks, German
quoted hunk ↗ jump to hunk
So remove the variable now. Signed-off-by: Salvatore Bonaccorso <redacted> --- tools/perf/dlfilters/dlfilter-test-api-v0.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/tools/perf/dlfilters/dlfilter-test-api-v0.c b/tools/perf/dlfilters/dlfilter-test-api-v0.c index 7565a1852c74..b17eb52a0694 100644 --- a/tools/perf/dlfilters/dlfilter-test-api-v0.c +++ b/tools/perf/dlfilters/dlfilter-test-api-v0.c@@ -308,8 +308,6 @@ int filter_event_early(void *data, const struct perf_dlfilter_sample *sample, vo int filter_event(void *data, const struct perf_dlfilter_sample *sample, void *ctx) { - struct filter_data *d = data; - pr_debug("%s API\n", __func__); return do_checks(data, sample, ctx, false);