Re: [PATCH v2 04/21] perf pmu: Make pmu_event tables const.

[PATCH v2 00/21] perf metric: Fixes and allow modifiers · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 01/21] tools lib: Add list_sort. · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 02/21] perf pmu: Add const to pmu_events_map. · Ian Rogers <irogers@google.com> · 2021-10-15
Re: [PATCH v2 02/21] perf pmu: Add const to pmu_events_map. · kajoljain <hidden> · 2021-10-26
[PATCH v2 03/21] perf pmu: Make pmu_sys_event_tables const. · Ian Rogers <irogers@google.com> · 2021-10-15
Re: [PATCH v2 03/21] perf pmu: Make pmu_sys_event_tables const. · John Garry <hidden> · 2021-10-19
Re: [PATCH v2 03/21] perf pmu: Make pmu_sys_event_tables const. · kajoljain <hidden> · 2021-10-26
[PATCH v2 04/21] perf pmu: Make pmu_event tables const. · Ian Rogers <irogers@google.com> · 2021-10-15
Re: [PATCH v2 04/21] perf pmu: Make pmu_event tables const. · John Garry <hidden> · 2021-10-19
Re: [PATCH v2 04/21] perf pmu: Make pmu_event tables const. · Arnaldo Carvalho de Melo <acme@kernel.org> · 2021-10-20
Re: [PATCH v2 04/21] perf pmu: Make pmu_event tables const. · kajoljain <hidden> · 2021-10-26
[PATCH v2 05/21] perf metric: Move runtime value to the expr context · Ian Rogers <irogers@google.com> · 2021-10-15
Re: [PATCH v2 05/21] perf metric: Move runtime value to the expr context · kajoljain <hidden> · 2021-10-26
[PATCH v2 06/21] perf metric: Add documentation and rename a variable. · Ian Rogers <irogers@google.com> · 2021-10-15
Re: [PATCH v2 06/21] perf metric: Add documentation and rename a variable. · kajoljain <hidden> · 2021-10-26
[PATCH v2 07/21] perf metric: Add metric new and free · Ian Rogers <irogers@google.com> · 2021-10-15
Re: [PATCH v2 07/21] perf metric: Add metric new and free · John Garry <hidden> · 2021-10-19
[PATCH v2 08/21] perf metric: Only add a referenced metric once · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 09/21] perf metric: Modify resolution and recursion check. · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 10/21] perf metric: Comment data structures. · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 11/21] perf metric: Document the internal 'struct metric' · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 12/21] perf metric: Simplify metric_refs calculation. · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 13/21] perf parse-events: Add const to evsel name · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 14/21] perf parse-events: Add new "metric-id" term. · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 15/21] perf parse-events: Allow config on kernel PMU events · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 16/21] perf metric: Encode and use metric-id as qualifier · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 17/21] perf expr: Add subset utility. · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 18/21] perf metrics: Modify setup and deduplication · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 19/21] perf metric: Switch fprintf to pr_err. · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 20/21] perf parse-events: Identify broken modifiers. · Ian Rogers <irogers@google.com> · 2021-10-15
[PATCH v2 21/21] perf metric: Allow modifiers on metrics. · Ian Rogers <irogers@google.com> · 2021-10-15
Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics. · Arnaldo Carvalho de Melo <acme@kernel.org> · 2021-10-19
Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics. · Arnaldo Carvalho de Melo <acme@kernel.org> · 2021-10-19
Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics. · Arnaldo Carvalho de Melo <acme@kernel.org> · 2021-10-19
Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics. · Arnaldo Carvalho de Melo <acme@kernel.org> · 2021-10-19
Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics. · Ian Rogers <irogers@google.com> · 2021-10-19
Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics. · Arnaldo Carvalho de Melo <hidden> · 2021-10-20
Re: [PATCH v2 00/21] perf metric: Fixes and allow modifiers · Arnaldo Carvalho de Melo <acme@kernel.org> · 2021-10-20

From: John Garry <hidden>
Date: 2021-10-19 11:16:42
Also in: lkml

On 15/10/2021 18:21, Ian Rogers wrote:

- bouncing Changbin Du [off-list ref] and Jin Yao 
[off-list ref]

Make lookup nature of data structures clearer through their type. Reduce
scope of architecture specific pmu_event tables by making them static.

Suggested-by: John Garry<redacted>
Acked-by: Andi Kleen<redacted>
Signed-off-by: Ian Rogers<irogers@google.com>

Reviewed-by: John Garry <redacted>

BTW, We seem to be using > 80 char per line now. Well in metricgroup.h 
anyway, from a brief check. I know checkpatch.pl is ok with this now, 
but some maintainers aren't. Just saying.

Thanks,
John

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help