Thread (3 messages) 3 messages, 2 authors, 2021-09-09

Re: [PATCH] perf test: Fix bpf test sample mismatch reporting

From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2021-09-09 13:21:30

Em Mon, Sep 06, 2021 at 04:26:31PM +0200, Michael Petlan escreveu:
Hi Arnaldo, please have a look.
This is still valid.
Thanks.
Michael
Looks correct, thanks for resending, applied.

- Arnaldo
 
On Thu, 5 Aug 2021, Michael Petlan wrote:
quoted
When the expected sample count in the condition changed, the message
needs to be changed too, otherwise we'll get:

  0x1001f2091d8: mmap mask[0]:
  BPF filter result incorrect, expected 56, got 56 samples

Fixes: 4b04e0decd25 ("perf test: Fix basic bpf filtering test")

Signed-off-by: Michael Petlan <redacted>
---
 tools/perf/tests/bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c
index dbf5f5215abe..fa03ff0dc083 100644
--- a/tools/perf/tests/bpf.c
+++ b/tools/perf/tests/bpf.c
@@ -192,7 +192,7 @@ static int do_test(struct bpf_object *obj, int (*func)(void),
 	}
 
 	if (count != expect * evlist->core.nr_entries) {
-		pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect, count);
+		pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect * evlist->core.nr_entries, count);
 		goto out_delete_evlist;
 	}
 
-- 
2.18.4
-- 

- Arnaldo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help