Em Thu, Sep 09, 2021 at 04:58:12PM -0500, Kim Phillips escreveu:

Hi Arnaldo,

Can you please take a look at applying this series?  Its kernel-side
dependent series has already been applied and is in Linus' master.

Sure, I'm now trying to fix this:

  CC      /tmp/build/perf/util/amd-sample-raw.o
util/amd-sample-raw.c: In function ‘evlist__amd_sample_raw’:
util/amd-sample-raw.c:125:42: error: ‘ bytes’ directive output may be truncated writing 6 bytes into a region of size between 4 and 7 [-Werror=format-truncation=]
  125 |                          " OpMemWidth %2d bytes", 1 << (reg.op_mem_width - 1));
      |                                          ^~~~~~
In file included from /usr/include/stdio.h:866,
                 from util/amd-sample-raw.c:7:
/usr/include/bits/stdio2.h:71:10: note: ‘__builtin___snprintf_chk’ output between 21 and 24 bytes into a destination of size 21
   71 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   72 |                                    __glibc_objsize (__s), __fmt,
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   73 |                                    __va_arg_pack ());
      |                                    ~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/util/amd-sample-raw.o] Error 1
 

Thanks,

Kim

On 8/17/21 5:15 PM, Kim Phillips wrote:

quoted

Hello Linux perf tools users and maintainers,

The first patch in this series prepares the perf tool to support
retrieving cpuid and pmu_mappings data when in report mode,
information that is needed to accurately decode IBS data.

The second patch adds a header file tools/arch/x86/include/asm/amd-ibs.h
from a separate kernel-side submittion [1].

The third patch allows the tool to print a textual representation
of the sample data recorded by IBS.

[1] https://lore.kernel.org/lkml/20210817221048.88063-9-kim.phillips@amd.com (local)

Kim Phillips (3):
   perf env: Add perf_env__cpuid, perf_env__{nr_}pmu_mappings
   perf report: Add tools/arch/x86/include/asm/amd-ibs.h
   perf report: Add support to print a textual representation of IBS raw
     sample data

  tools/arch/x86/include/asm/amd-ibs.h | 132 ++++++++++++
  tools/perf/check-headers.sh          |   1 +
  tools/perf/util/Build                |   1 +
  tools/perf/util/amd-sample-raw.c     | 290 +++++++++++++++++++++++++++
  tools/perf/util/env.c                |  78 +++++++
  tools/perf/util/env.h                |   5 +
  tools/perf/util/sample-raw.c         |   8 +
  tools/perf/util/sample-raw.h         |   6 +-
  8 files changed, 520 insertions(+), 1 deletion(-)
  create mode 100644 tools/arch/x86/include/asm/amd-ibs.h
  create mode 100644 tools/perf/util/amd-sample-raw.c

Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <redacted>
Cc: Joao Martins <redacted>
Cc: Konrad Rzeszutek Wilk <redacted>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <redacted>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <redacted>
Cc: Stephane Eranian <redacted>
Cc: linux-kernel@vger.kernel.org
Cc: linux-perf-users@vger.kernel.org

-- 

- Arnaldo