Thread (26 messages) 26 messages, 3 authors, 2021-08-30

Re: [PATCH 17/17] vsprintf: rework bitmap_list_string

From: Yury Norov <yury.norov@gmail.com>
Date: 2021-08-26 20:59:13
Also in: kvm, linux-arch, linux-kselftest, linux-mm, linux-mmc, lkml

On Thu, Aug 26, 2021 at 04:15:09PM +0200, Petr Mladek wrote:
On Sat 2021-08-14 14:17:13, Yury Norov wrote:
quoted
bitmap_list_string() is very ineffective when printing bitmaps with long
ranges of set bits because it calls find_next_bit for each bit in the
bitmap.  We can do better by detecting ranges of set bits.

In my environment, before/after is 943008/31008 ns.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
I like the patch. The new code is much easier to follow.
Feel free to use:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr
Thanks Petr! The patch is already in the linux-next.

Andrew, Stephen, can you please append Petr's reviewed-by?

Thanks,
Yury
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help