Re: [PATCH] perf config: fix caching and memory leak in perf_home_perfconfig

Em Fri, Aug 20, 2021 at 09:58:16PM +0200, Riccardo Mancini escreveu:

On Fri, 2021-08-20 at 11:13 -0300, Arnaldo Carvalho de Melo wrote:

quoted

diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 63d472b336de21d4..4fb5e90d7a57ae48 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c

@@ -581,7 +581,10 @@ const char *perf_home_perfconfig(void)

        static const char *config;
        static bool failed;
 
-       config = failed ? NULL : home_perfconfig();
+       if (failed || config)
+               return config;
+
+       config = home_perfconfig();
        if (!config)
                failed = true;
 

Looks good to me.
Shall I resend it fixed?

No need, I'll fix it and apply, thanks for checking!

- Arnaldo