Thread (21 messages) 21 messages, 5 authors, 2021-06-28

Re: [PATCH v1 0/3] coresight: Fix for snapshot mode

From: Leo Yan <hidden>
Date: 2021-06-22 12:58:21
Also in: linux-arm-kernel, lkml

Hi Denis,

On Sun, Jun 20, 2021 at 10:21:57PM -1000, Denis Nikitin wrote:

[...]
quoted
I'd like to leave patch 1/3 out, and resend it if we get conclusion.
At the meantime, @Denis, if you have observed any profiling result
(or profiling quality) difference caused by patch 1, the feedback would
be very valuable.
I evaluated AutoFDO profiles with benchmarks but I was only focused
on the system-wide mode. And as I understood patch 1 fixes the issue
in non system-wide mode.
Yes, patch 1 doesn't work for the system-wide mode.  In the system-wide
mode, CoreSight driver has its own reference counter to only allow the
last CPU to fill trace data to AUX buffer.
Currently I'm OoO so I won't be able to do further evaluation.
No problem, thanks for the feedback!

Leo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help