Thread (3 messages) 3 messages, 2 authors, 2021-06-09
DORMANTno replies

[PATCH v2] perf: events: make perf_pmu_snapshot_aux static

From: Pavel Skripkin <hidden>
Date: 2021-06-09 09:39:19
Also in: lkml
Subsystem: performance events subsystem, the rest · Maintainers: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Linus Torvalds

Sparse says:
  warning: symbol 'perf_pmu_snapshot_aux' was not declared. Should it be static?

Since perf_pmu_snapshot_aux() is not used outside this file,
it can be made static

Signed-off-by: Pavel Skripkin <redacted>
---

Changes in v2:
	Changed subject line
	Fixed alignment of the arguments

---
 kernel/events/core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 6fee4a7e88d7..9ad01ff5692b 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6667,10 +6667,10 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
 	return data->aux_size;
 }
 
-long perf_pmu_snapshot_aux(struct perf_buffer *rb,
-			   struct perf_event *event,
-			   struct perf_output_handle *handle,
-			   unsigned long size)
+static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
+				  struct perf_event *event,
+				  struct perf_output_handle *handle,
+				  unsigned long size)
 {
 	unsigned long flags;
 	long ret;
-- 
2.31.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help