Thread (2 messages) 2 messages, 2 authors, 2021-06-08

Re: [PATCH -next] perf tools: Use list_move instead of list_del/list_add

From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2021-06-08 12:45:21
Also in: lkml

Em Tue, Jun 08, 2021 at 08:52:46AM +0800, Zou Wei escreveu:
Using list_move() instead of list_del() + list_add().
Thanks, applied.

- Arnaldo

 
quoted hunk ↗ jump to hunk
Reported-by: Hulk Robot <redacted>
Signed-off-by: Zou Wei <redacted>
---
 tools/perf/util/srccode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/srccode.c b/tools/perf/util/srccode.c
index c29edaa..476e998 100644
--- a/tools/perf/util/srccode.c
+++ b/tools/perf/util/srccode.c
@@ -97,8 +97,7 @@ static struct srcfile *find_srcfile(char *fn)
 	hlist_for_each_entry (h, &srcfile_htab[hval], hash_nd) {
 		if (!strcmp(fn, h->fn)) {
 			/* Move to front */
-			list_del(&h->nd);
-			list_add(&h->nd, &srcfile_list);
+			list_move(&h->nd, &srcfile_list);
 			return h;
 		}
 	}
-- 
2.6.2
-- 

- Arnaldo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help