Re: [PATCH] perf symbol-elf: fix memory leak: free sdt_note.args
From: Ian Rogers <irogers@google.com>
Date: 2021-06-04 04:09:20
Also in:
lkml
On Wed, Jun 2, 2021 at 3:12 PM Riccardo Mancini [off-list ref] wrote:
Reported by ASan.
Did you have a reproducer for getting this to fail?
Signed-off-by: Riccardo Mancini <redacted>
Acked-by: Ian Rogers <irogers@google.com> Thanks, Ian
quoted hunk ↗ jump to hunk
--- tools/perf/util/symbol-elf.c | 1 + 1 file changed, 1 insertion(+)diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 4c56aa8374344..a73345730ba90 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c@@ -2412,6 +2412,7 @@ int cleanup_sdt_note_list(struct list_head *sdt_notes) list_for_each_entry_safe(pos, tmp, sdt_notes, note_list) { list_del_init(&pos->note_list); + zfree(&pos->args); zfree(&pos->name); zfree(&pos->provider); free(pos); --2.31.1