Thread (3 messages) 3 messages, 2 authors, 2021-05-26

Re:[PATCH] perf core: Fix some kernel-doc warnings.

From: Haocheng Xie <hidden>
Date: 2021-05-26 09:46:58
Also in: lkml

Ingo Molnar [off-list ref] wrote:

* Haocheng Xie [off-list ref] wrote:
quoted
Fix the following W=1 kernel build warning(s):
kernel/events/core.c:143: warning: Function parameter or member 'cpu' not described in 'cpu_function_call'
kernel/events/core.c:11924: warning: Function parameter or member 'flags' not described in 'sys_perf_event_open'
kernel/events/core.c:12382: warning: Function parameter or member 'overflow_handler' not described in 'perf_event_create_kernel_counter'
kernel/events/core.c:12382: warning: Function parameter or member 'context' not described in 'perf_event_create_kernel_counter'

Signed-off-by: Haocheng Xie <redacted>
Even with your two patches there's still W=1 warnings remaining in
kernel/events/:

  kernel/events/hw_breakpoint.c:461: warning: Function parameter or member 'context' not described in 'register_user_hw_breakpoint'
  kernel/events/hw_breakpoint.c:560: warning: Function parameter or member 'context' not described in 'register_wide_hw_breakpoint'

Could you please fix all of them, and send them as a 3-patch series?
OK, I will fix these warnings and resend the 3-patch series later.
Doesn't make much sense to just partially fix W=1 warnings in a subsystem.

Thanks,

        Ingo
Thanks for your kind advice.

Best regards,

Haocheng Xie
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help