Re: [PATCH] perf config: add annotate.demangle{,_kernel}
From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2021-03-06 13:22:55
Also in:
lkml
Em Fri, Feb 26, 2021 at 11:08:12AM +0100, Martin Liška escreveu:
On 2/26/21 11:03 AM, Martin Liška wrote:quoted
On 2/23/21 8:49 PM, Arnaldo Carvalho de Melo wrote:quoted
Please consider making this configurable (if not already) via ~/.perfconfig, 'perf config', sure in a followup patch.I'm doing that in the following patch.The patch contained a typo, fixed in the V2.
Thanks, applied.
And expanded that commit log a bit:
Author: Martin Liska [off-list ref]
Date: Fri Feb 26 11:01:24 2021 +0100
perf config: Add annotate.demangle{,_kernel}
Committer notes:
This allows setting this in from the command line:
$ perf config annotate.demangle
$ perf config annotate.demangle=yes
$ perf config annotate.demangle
annotate.demangle=yes
$ cat ~/.perfconfig
# this file is auto-generated.
[report]
sort-order = srcline
[annotate]
demangle = yes
$
$
$ perf config annotate.demangle_kernel
$ perf config annotate.demangle_kernel=yes
$ perf config annotate.demangle_kernel
annotate.demangle_kernel=yes
$ cat ~/.perfconfig
# this file is auto-generated.
[report]
sort-order = srcline
[annotate]
demangle = yes
demangle_kernel = yes
$
Signed-off-by: Martin Liška [off-list ref]
Tested-by: Arnaldo Carvalho de Melo [off-list ref]
Link: https://lore.kernel.org/r/c96aabe7-791f-9503-295f-3147a9d19b60@suse.cz (local)
Signed-off-by: Arnaldo Carvalho de Melo [off-list ref]
- Arnaldo
Martinquoted
Thanks, Martin
quoted hunk ↗ jump to hunk
From a29a6d3ae717f19774a430ccf9a63a452376f359 Mon Sep 17 00:00:00 2001 From: Martin Liska <redacted> Date: Fri, 26 Feb 2021 11:01:24 +0100 Subject: [PATCH] perf config: add annotate.demangle{,_kernel} MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Martin Liška <redacted> --- tools/perf/Documentation/perf-config.txt | 6 ++++++ tools/perf/util/annotate.c | 4 ++++ 2 files changed, 10 insertions(+)diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt index 153bde14bbe0..154a1ced72b2 100644 --- a/tools/perf/Documentation/perf-config.txt +++ b/tools/perf/Documentation/perf-config.txt@@ -393,6 +393,12 @@ annotate.*:: This option works with tui, stdio2 browsers. + annotate.demangle:: + Demangle symbol names to human readable form. Default is 'true'. + + annotate.demangle_kernel:: + Demangle kernel symbol names to human readable form. Default is 'true'. + hist.*:: hist.percentage:: This option control the way to calculate overhead of filtered entries -diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 80542012ec1b..e35d56608986 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c@@ -3142,6 +3142,10 @@ static int annotation__config(const char *var, const char *value, void *data) opt->use_offset = perf_config_bool("use_offset", value); } else if (!strcmp(var, "annotate.disassembler_style")) { opt->disassembler_style = value; + } else if (!strcmp(var, "annotate.demangle")) { + symbol_conf.demangle = perf_config_bool("demangle", value); + } else if (!strcmp(var, "annotate.demangle_kernel")) { + symbol_conf.demangle_kernel = perf_config_bool("demangle_kernel", value); } else { pr_debug("%s variable unknown, ignoring...", var); }-- 2.30.1
-- - Arnaldo