Thread (43 messages) 43 messages, 7 authors, 2018-11-05

Re: [PATCH 17/28] tools include uapi: Update asound.h copy

From: Takashi Iwai <hidden>
Date: 2018-10-31 18:32:33
Also in: lkml

On Wed, 31 Oct 2018 18:27:02 +0100,
Joe Perches wrote:
On Wed, 2018-10-31 at 18:00 +0100, Takashi Iwai wrote:
quoted
On Wed, 31 Oct 2018 17:44:57 +0100,
Arnaldo Carvalho de Melo wrote:
quoted
From: Arnaldo Carvalho de Melo <redacted>

To silence this perf build warning:

  Warning: Kernel ABI header at 'tools/include/uapi/sound/asound.h' differs from latest version at 'include/uapi/sound/asound.h'
  diff -u tools/include/uapi/sound/asound.h include/uapi/sound/asound.h

Due to this cset:

  a98401518def ("ALSA: timer: fix wrong comment to refer to 'SNDRV_TIMER_PSFLG_*'")

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Takashi Iwai <redacted>
Link: https://lkml.kernel.org/n/tip-76gsvs0w2g0x723ivqa2xua3@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <redacted>
Thanks for the correction.

That's bad to have duped files that have to be synced manually...
At least, some checkpatch addition would help to suggest always
correct both places?
How could that work in checkpatch?
Didn't consider yet :)
Wouldn't a symlink be simpler?
I thought of that, too, but there must be a reason not to do so...


Takashi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help