Thread (7 messages) 7 messages, 3 authors, 2018-03-12

Re: [PATCH RESEND v5] perf/core: Fix installing arbitrary cgroup event into cpu

From: Ingo Molnar <mingo@kernel.org>
Date: 2018-03-12 07:53:13
Also in: lkml

* linxiulei@gmail.com [off-list ref] wrote:
 	/*
 	 * Because cgroup events are always per-cpu events,
 	 * this will always be called from the right CPU.
 	 */
+	/*
+	 * if only the cgroup is running on this cpu
+	 * and cpuctx->cgrp == NULL (otherwise it would've
+	 * been set with running cgroup), we put this cgroup
+	 * into cpu context. Or it would case mismatch in
+	 * following cgroup events at event_filter_match()
+	 */
Beyond making sure that what you comment on makes sense, please also follow 
existing comment style, which I quoted above.

There's 3 separate mistakes in that paragraph alone.

Thanks,

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help