Re: [PATCH 1/2] perf report fix module symbol adjustment for s390x
From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2017-08-03 12:45:50
From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2017-08-03 12:45:50
Em Thu, Aug 03, 2017 at 11:37:02AM +0200, Thomas-Mich Richter escreveu:
On 08/02/2017 08:42 PM, Arnaldo Carvalho de Melo wrote:quoted
Then have it as: - /* Adjust symbol to map to file offset */ if (adjust_kernel_syms) - sym.st_value -= shdr.sh_addr - shdr.sh_offset; + arch__adjust_sym_map_offset(&sym, &shdr, map);
quoted
I.e. the weak function name becomes the comment :-)
Ok , I will provide a version 2 with your findings fixed. I'll include a Reviewed-by: if this is ok with you.
yeah. - Arnaldo