Em Fri, Aug 07, 2015 at 09:31:41AM +0800, Wangnan (F) escreveu:

On 2015/8/6 21:17, Arnaldo Carvalho de Melo wrote:

quoted

Em Thu, Aug 06, 2015 at 11:53:42AM +0200, Milian Wolff escreveu:

quoted

On Thursday 06 August 2015 11:24:29 Milian Wolff wrote:
<snip>

quoted

Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Signed-off-by: Milian Wolff <redacted>

I hope this patch is OK. I have some more questions:

It is. I did just minor reflowing, consistency changes to the commit log
message, things I do while reading the patch description, added a
Tested-by: me, as I did more than just compile test and cursory review,
actually taking the time to run it and see the results, etc.

Here it is:

https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=237f0f8d473c6bc1952c649267b8b3be5dbaa5d9

quoted

a) Should I always send to linux-kernel and CC linux-perf-users, or is it OK
to send it only to linux-perf-users?

So far, the mailing list for development is
linux-kernel@vger.kernel.org, so please keep it on the CC list.

Keeping linux-perf-users@vger.kernel.org may reach people that can't
stand the volume of lkml tho.

quoted

b) Should I put you explicitly into the CC, I recon you also read the mailing
lists?

Yes, you should, that way it'll go to my main inbox, in addition to the
list folder.

No need to put me, or Ingo or PeterZ on the patch description CC list,
just on the e-mail CC list.

There are people who work on each tool from time to time, so sometimes
its a good idea to do a 'git blame' in the parts of the code you change
to add them to the CC list, both in the e-mail and in the patch
description.

In the e-mail because we want them to straight away receive a
notification that changes are being made in areas they worked on, and in
the CC list in the description message because we want to have that
documented in the source code repository (hey, they were warned!).

My scripts will pick whoever is in the CC list in the e-mail to add them
to the CC list in the commit log, but this only when I process directly
from e-mail.

Preferably those rules are followed by whoever asks me to apply patches,
so that, for frequent contributors we can eventually work on a 'git
pull' way.

I.e. you post patches to the mailing list together with a "git
request-pull" generated cover letter that provides instructions for me
to do a 'git pull' from some publicly accessible git server, preferably
hosted at git.kernel.org, but that, again, for frequent patch submitters
that follow these rules.

Thank you to CC-ing me this mail. I have a further question: shall I keep
Cc list in commit log in my git tree commits, and remove then when
I send them to mailing list?

Keep the CC list, as it will be used when you do:

  git format-patch -n --cover-letter tip/perf/core..

Then you'll create a signed tag with:

git tag -u 5352AA40 perf-core-for-mingo

Edit 0000-cover-letter, to include the output of:

  git request-pull tip/perf/core git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf-core-for-mingo >> 0000-cover-letter.patch

Replace 'perf-core-for-mingo' with a suitable name, perhaps
'perf-bpf-for-acme', or something to that effect.

You will use that gpg key that you created to get access to the
kernel.org account.

- Arnaldo