On Tuesday 13 January 2015 07:18 AM, Arnaldo Carvalho de Melo wrote:

Em Mon, Jan 12, 2015 at 12:05:22PM +0100, Jiri Olsa escreveu:

On Sat, Jan 10, 2015 at 04:40:50PM +0530, Vineet Gupta wrote:

quoted

From: Alexey Brodkin <abrodkin@synopsys.com><mailto:abrodkin@synopsys.com>

ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers
statfs defines f_type to be U32 which causes perf build breakage

http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h

----------->8---------------
  CC       fs/fs.o
fs/fs.c: In function 'fs__valid_mount':
fs/fs.c:82:24: error: comparison between signed and unsigned integer
expressions [-Werror=sign-compare]
  else if (st_fs.f_type != magic)
                        ^
cc1: all warnings being treated as errors
----------->8---------------

Cc: Borislav Petkov <redacted><mailto:bp@suse.de>
Cc: Jiri Olsa <jolsa@kernel.org><mailto:jolsa@kernel.org>
Cc: Cody P Schafer <redacted><mailto:dev@codyps.com>
Cc: Arnaldo Carvalho de Melo <redacted><mailto:acme@redhat.com>
Cc: linux-perf-users@vger.kernel.org<mailto:linux-perf-users@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org<mailto:linux-kernel@vger.kernel.org>
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com><mailto:abrodkin@synopsys.com>

Acked-by: Jiri Olsa <jolsa@kernel.org><mailto:jolsa@kernel.org>

Thanks, applied, but please do not start lines in the changelog comment
with ---, that breaks some patch applying scripts. I fixed it up this
time.

Thx. I've udpated the changelogs so scissor lines start at column 3 with leading whitespace, is that OK or do you want me to remove those lines altogether. Also do u want me to drop this patch from v3 of series as I have some fixups for other patches.

Thx,
-Vineet



- Arnaldo