Re: [PATCH] perf tools: Emit clearer message for sys_perf_event_open ENOENT return
From: Arnaldo Carvalho de Melo <hidden>
Date: 2011-03-25 18:37:53
Also in:
lkml
From: Arnaldo Carvalho de Melo <hidden>
Date: 2011-03-25 18:37:53
Also in:
lkml
Em Fri, Mar 25, 2011 at 12:26:41PM -0600, David Ahern escreveu:
On 03/25/11 12:08, Arnaldo Carvalho de Melo wrote:quoted
Em Fri, Mar 25, 2011 at 12:05:50PM -0600, David Ahern escreveu:quoted
Resend of patch sent back in January 2011 in light of recent confusion around unsupported events for a given platform. Improve sys_perf_event_open ENOENT return handling in top and record, just like 5a3446b does for stat. Retry of Arnaldo's patch using error instead of die which allows the fallback from hardware cycles to software clock.Please use ui__warning(""...) as it will work in the TUI too.error() is consistent with current pattern. Is ui__warning the preference for new messages? Is that for perf-top only?
Yes, it is, it takes care of using TUI of doing it like error() does. Eventually error(), etc will go away. - Arnaldo