Re: [PATCH] Add inverted call graph report support to perf tool
From: Arun Sharma <hidden>
Date: 2011-03-17 17:53:47
Also in:
lkml
On Mon, Mar 07, 2011 at 09:43:27PM +0800, Sam Liao wrote:
+
+ /* reverse call chain data */
+ if (reverse_call && symbol_conf.use_callchain && sample->callchain) {
You probably want to check for nr > 1 here, as in:
/* reverse call chain data */
- if (reverse_call && symbol_conf.use_callchain && sample->callchain) {
+ if (reverse_call && symbol_conf.use_callchain && sample->callchain
+ && (sample->callchain->nr > 1)) {
struct ip_callchain *chain;
int i, j;
u64 tmp_ip;
Otherwise, if you get a callchain with ->nr == 0, the loop with (nr - 2) will
go on for a long time.
-Arun