Thread (108 messages) 108 messages, 17 authors, 2022-01-30

Re: [RFC 04/32] parport: PC style parport depends on HAS_IOPORT

From: Arnd Bergmann <arnd@kernel.org>
Date: 2021-12-29 02:59:09
Also in: linux-arch, linux-riscv, lkml

On Tue, Dec 28, 2021 at 5:14 AM Geert Uytterhoeven [off-list ref] wrote:
Hi Niklas,

On Mon, Dec 27, 2021 at 5:48 PM Niklas Schnelle [off-list ref] wrote:
quoted
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
not being declared. As PC style parport uses these functions we need to
handle this dependency for HAS_IOPORT.

Co-developed-by: Arnd Bergmann <arnd@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@kernel.org>
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Thanks for your patch!
quoted
--- a/drivers/parport/Kconfig
+++ b/drivers/parport/Kconfig
@@ -14,7 +14,6 @@ config ARCH_MIGHT_HAVE_PC_PARPORT

 menuconfig PARPORT
        tristate "Parallel port support"
-       depends on HAS_IOMEM
Why drop this?
Don't all other parport drivers depend on it?
The other drivers all have dependencies on specific platforms, so I
probably dropped it in the original draft because the remaining dependencies
are sufficient.

Technically, the partport_pc driver only needs HAS_IOPORT, not HAS_IOMEM,
but in the end this makes very little difference.

        Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help