Re: [PATCH v2 07/13] PCI: aardvark: Do not unmask unused interrupts

From
Lorenzo Pieralisi <hidden>
Date
2021-10-07 13:27:55
Reply to
Marek Behún, 2021-10-06
On Wed, Oct 06, 2021 at 12:28:23PM +0200, Marek Behún wrote:
On Wed, 6 Oct 2021 10:13:38 +0100
Lorenzo Pieralisi [off-list ref] wrote:
quoted
[CC Sasha for stable kernel rules]

On Tue, Oct 05, 2021 at 08:09:46PM +0200, Marek Behún wrote:
quoted
From: Pali Rohár <pali@kernel.org>

There are lot of undocumented interrupt bits. Fix all *_ALL_MASK macros to
define all interrupt bits, so that driver can properly mask all interrupts,
including those which are undocumented.

Fixes: 8c39d710363c ("PCI: aardvark: Add Aardvark PCI host controller driver")
Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Cc: <redacted>  
I don't think this is a fix and I don't think it should be sent
to stable kernels in _preparation_ for other fixes to come (that
may never land in mainline).
This patch is a fix because it fixes masking interrupts, which may
prevent spurious interrupts - we don't want interrupts which kernel
didn't request for.

I agree that the commit message should probably mention this, though...
:(
Now it does ;-), will notify you when I push the series out so that
you can have a look to check.

Thanks,
Lorenzo
Marek
Thread (21 messages) 21 messages, 2 authors, last reply 2021-10-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help