On Wed, Sep 29, 2021 at 8:55 PM Arnd Bergmann [off-list ref] wrote:

On Wed, Sep 29, 2021 at 6:32 PM Bjorn Helgaas [off-list ref] wrote:

quoted

On Wed, Sep 29, 2021 at 03:55:09PM +0100, Lorenzo Pieralisi wrote:

quoted

On Wed, Sep 22, 2021 at 01:13:11AM +0200, Marek Vasut wrote:

quoted

On 9/21/21 6:08 PM, Geert Uytterhoeven wrote:

[...]

quoted

quoted

diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 326f7d13024f..ee6f5e525d3a 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig

@@ -66,6 +66,7 @@ config PCI_RCAR_GEN2
  config PCIE_RCAR_HOST
         bool "Renesas R-Car PCIe host controller"
         depends on ARCH_RENESAS || COMPILE_TEST
+       depends on COMMON_CLK

Bjorn, shall we pick Arnd's patch up then ? We should be fixing this in
one of the upcoming -rcs since we introduced it in the last merge
window.

IIUC, a115b1bd3af0 ("PCI: rcar: Add L1 link state fix into data abort
hook") appeared in v5.15-rc1 and added a use of __clk_is_enabled(),
which is only available when COMMON_CLK=y.

PCIE_RCAR_HOST depends on ARCH_RENESAS || COMPILE_TEST.  ARCH_RENESAS
is an ARM64 platform, so when COMPILE_TEST is not set, I think we get
COMMON_CLK=y via this:

  config ARM64
    select COMMON_CLK

But when ARCH_RENESAS is not set and COMPILE_TEST=y, there's nothing
that enforces the dependency on COMMON_CLK.  Personally I like the
first hunk of Marek's patch at [1] because the dependency on
COMMON_CLK is explicit:

  config PCIE_RCAR_HOST
    depends on ARCH_RENESAS || COMPILE_TEST
    depends on COMMON_CLK

Agreed, Marek's version is clearer than mine, please use that.

But PCIE_RCAR_EP does not need the dependency.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds