Thread (1 message) 1 message, 1 author, 2021-08-17

Re: [PATCH v2] PCIe: limit Max Read Request Size on i.MX to 512 bytes

From: Krzysztof Hałasa <khalasa@piap.pl>
Date: 2021-08-17 04:29:30
Also in: lkml

Rob Herring [off-list ref] writes:
quoted
+#ifdef CONFIG_ARM
+       if (rq > max_pcie_mrrs)
+               rq = max_pcie_mrrs;
+#endif
My objection wasn't having another kconfig option so much as I don't
think we need one at all here unless Bjorn feels otherwise. It's 2
bytes of data and about 3 instructions (load, cmp, store).

If we do have a config option, using or basing on the arch is wrong.
Has nothing to do with the arch. Are the other platforms needing this
arm32 as well?
Yes,

I can buy the "universal ARM32 kernel" argument, but otherwise it's just
nonfunctional bloat. A small one, yes.
-- 
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help