Re: [PATCH] PCI: Remove duplicate #ifdef in pci_try_set_mwi()
From: Greg KH <hidden>
Date: 2021-08-12 06:49:27
Also in:
linux-kernel-mentees, lkml
On Thu, Aug 12, 2021 at 05:16:01AM +0530, Utkarsh Verma wrote:
quoted hunk ↗ jump to hunk
Remove the unnecessary #ifdef PCI_DISABLE_MWI, because pci_set_mwi() performs the same check. Signed-off-by: Utkarsh Verma <redacted> --- drivers/pci/pci.c | 4 ---- 1 file changed, 4 deletions(-)diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index aacf575c15cf..7d4c7c294ef2 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c@@ -4456,11 +4456,7 @@ EXPORT_SYMBOL(pcim_set_mwi); */ int pci_try_set_mwi(struct pci_dev *dev) { -#ifdef PCI_DISABLE_MWI - return 0; -#else return pci_set_mwi(dev); -#endif } EXPORT_SYMBOL(pci_try_set_mwi);
If this is the case, why do we even need pci_try_set_mwi()? Why not just replace it with calls to pci_set_mwi() and then delete this one? thanks, greg k-h