Re: [PATCH 12/12] vfio/pci: Introduce vfio_pci_core.ko
From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-07-28 13:08:55
Also in:
kvm, linux-doc, linux-kbuild, linux-s390
On Wed, Jul 28, 2021 at 2:47 PM Jason Gunthorpe [off-list ref] wrote:
On Wed, Jul 28, 2021 at 02:29:56PM +0200, Christoph Hellwig wrote:quoted
So not really an issue here. VFIO_PCI_CORE really is underlying infrastructure a user should not care about.So then we can write it like below? Unfortunately it deletes the nice menu structure that groups all the PCI drivers together like platform (and mdev in future). Not sure this loss is worth the backwards compat
I think you can get back some structure by adding a 'menu "VFIO PCI drivers"' and 'endmenu' around it.
quoted hunk ↗ jump to hunk
@@ -17,6 +15,7 @@ config VFIO_PCI_INTX config VFIO_PCI tristate "Generic VFIO support for any PCI device" + select VFIO_PCI_CORE help Support for the generic PCI VFIO bus driver which can connect any PCI device to the VFIO framework.@@ -50,6 +49,7 @@ endif config MLX5_VFIO_PCI tristate "VFIO support for MLX5 PCI devices" depends on MLX5_CORE + select VFIO_PCI_CORE help
These two now have to get a 'depends on MMU' if they don't already inherit
that from elsewhere.
Arnd