On 12/15/2016 07:36 AM, Thomas Gleixner wrote:

On Thu, 15 Dec 2016, Gavin Shan wrote:

quoted

quoted

static int get_nodes_in_cpumask(const struct cpumask *mask, nodemask_t *nodemsk)
{
-	int n, nodes;
+	int n, nodes = 0;

	/* Calculate the number of nodes in the supplied affinity mask */
-	for (n = 0, nodes = 0; n < num_online_nodes(); n++) {
+	for_each_online_node(n)
		if (cpumask_intersects(mask, cpumask_of_node(n))) {
			node_set(n, *nodemsk);
			nodes++;
		}
-	}
+

It'd better to keep the brackets so that we needn't add them when adding
more code into the block next time.

Removing the brackets is outright wrong. See:
  https://marc.info/?l=linux-kernel&m=147351236615103

I'll fix that up when applying the patch.

Thanks,

	tglx

Thanks you all very much for the reviews and comments - lesson learned
about the brackets in multi-line if/for statements!

Thanks for fixing it Thomas.
Cheers,


Guilherme