Re: [PATCH v4 09/15] drivers: acpi: iort: add support for ARM SMMU platform devices creation
From: Lorenzo Pieralisi <hidden>
Date: 2016-08-18 10:56:05
Also in:
linux-acpi, linux-arm-kernel, linux-iommu, lkml
On Thu, Aug 18, 2016 at 06:50:07PM +0800, Dennis Chen wrote: [...]
quoted
+static void __init iort_smmu_init(void) +{ + struct acpi_iort_node *iort_node, *iort_end; + struct acpi_table_iort *iort; + struct fwnode_handle *fwnode; + int i, ret; + + /* + * table and iort will both point to the start of IORT table, but + * have different struct types + */ + iort = (struct acpi_table_iort *)iort_table;If the firmware of a platform happens to miss the IORT table, then iort_table here will be a NULL pointer, in this case 'NULL pointer dereference' kernel panic will occur, if this is not an expected behavior then we can add a sanity check here to avoid this. IORT missing is a fatal error? I don't think so.
Yes, I've already fixed it, thanks for pointing that out. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel