Thread (4 messages) 4 messages, 2 authors, 2012-09-17

Re: [PATCH] pci: rewrite pci_call_probe() to use workqueue instead of work_on_cpu()

From: Bjorn Helgaas <bhelgaas@google.com>
Date: 2012-09-17 21:46:04
Also in: lkml

On Mon, Sep 17, 2012 at 3:41 PM, Tejun Heo [off-list ref] wrote:
On Fri, Sep 14, 2012 at 12:13:21PM -0600, Bjorn Helgaas wrote:
quoted
On Thu, Aug 23, 2012 at 3:35 PM, Tejun Heo [off-list ref] wrote:
quoted
pci_call_probe() uses work_on_cpu(), which creates and tears down a
full kthread on each call, to invoke ->probe() on node local CPU for
allocation affinity.

The same goal can easily be achieved using a work item.  This patch
rewrites pci_call_probe() so that it uses a work item instead of
work_on_cpu().

Note that the function is restructured for simplicity.  This adds
get/put_online_cpus() pair for devices without node but the overhead
of doing so isn't anything material at this level.

Signed-off-by: Tejun Heo <tj@kernel.org>
I applied this to my "next" branch and pushed it.  Thanks!
Can you please drop / revert this one?  It seems we need work_on_cpu()
after all and I'm gonna reimplement it in sane way.
I dropped it.  Thanks for the heads-up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help