Re: [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver
From: Stephen Warren <hidden>
Date: 2012-03-09 16:42:32
Also in:
linux-arm-kernel, linux-devicetree, linux-tegra
Possibly related (same subject, not in this thread)
- 2012-03-09 · Re: [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver · Thierry Reding <hidden>
- 2012-03-08 · Re: [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver · Stephen Warren <hidden>
- 2012-03-08 · [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver · Thierry Reding <hidden>
On 03/08/2012 11:37 PM, Thierry Reding wrote:
* Stephen Warren wrote:quoted
On 03/08/2012 07:51 AM, Thierry Reding wrote:quoted
Signed-off-by: Thierry Reding <redacted>
...
quoted
quoted
diff --git a/arch/arm/mach-tegra/board.h b/arch/arm/mach-tegra/board.hquoted
+#define TEGRA_PCIE_MAX_PORTS 2 + +struct tegra_pcie_pdata { + int (*init)(struct platform_device *pdev); + int (*exit)(struct platform_device *pdev); + bool enable_ports[TEGRA_PCIE_MAX_PORTS]; +};That's a somewhat odd place to put the header; a dedicated mach-tegra/include/mach/tegra_pcie_pdata.h or include/linux/platform_data/tegra_pcie.h might make more sense.mach-tegra/include/mach/pcie.h perhaps? That would be less redundant.
New files in that directory should have tegra in the name somewhere, so that when multi-SoC kernels are built, and multiple mach-*/include/mach directories are in the include path (or files get moved from those paths into a single common place), you know which include file you're getting.