Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status
From: Tony Lindgren <tony@atomide.com>
Date: 2021-08-11 06:12:20
Also in:
linux-arm-kernel, lkml
From: Tony Lindgren <tony@atomide.com>
Date: 2021-08-11 06:12:20
Also in:
linux-arm-kernel, lkml
* Tony Lindgren [off-list ref] [210810 12:52]:
* Pavel Machek [off-list ref] [210810 12:40]:quoted
What is going on here? First, we silently ignore errors other than EBUSY. Second, sysc_check_active_timer() can't return -EBUSY: it returns either 0 or -ENXIO. (I checked 5.10-stable, mainline and -next-20210806).Thanks for spotting it, looks like there's now a conflict with commit 65fb73676112 ("bus: ti-sysc: suppress err msg for timers used as clockevent/source"). It seems we should also check for -ENXIO here too. And yeah it makes sens to return on other errors for sure.
FYI, fix posted at [0] below. Regards, Tony [0] https://lore.kernel.org/linux-omap/20210811061053.32081-1-tony@atomide.com/T/#u (local)