Re: [PATCH 1/2] usb: musb: musb_cppi41: Fix the address of teardown and autoreq registers
From: Sekhar Nori <hidden>
Date: 2017-08-14 13:31:52
Hi, On Sunday 13 August 2017 05:34 PM, Alexandre Bailon wrote:
quoted hunk
The DA8xx and DSPS platforms don't use the same address for few registers. On Da8xx, this is causing some issues (e.g. teardown that doesn't work). Configure the address of the register during the init and use them instead of constants. Reported-by: nsekhar-l0cyMroinI0@public.gmane.org Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> --- drivers/usb/musb/musb_cppi41.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-)diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c index ba255280a624..dbff0e0a4ff5 100644 --- a/drivers/usb/musb/musb_cppi41.c +++ b/drivers/usb/musb/musb_cppi41.c@@ -26,6 +26,9 @@ #define MUSB_DMA_NUM_CHANNELS 15 +#define DA8XX_USB_AUTOREQ_REG 0x14 +#define DA8XX_USB_TEARDOWN_REG 0x1c
Nice catch. I noticed that the USB_CTRL_TX_MODE and USB_CTRL_RX_MODE are incorrect for DA8xx too. Perhaps those should be fixed too. Also, since the original code does not use the _REG suffix for register offsets, perhaps the new defines should avoid those as well for consistency. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html