Re: [PATCH v10 08/14] usb: otg: add OTG/dual-role core
From: Peter Chen <hidden>
Date: 2016-06-12 11:27:15
Also in:
linux-devicetree, lkml
On Fri, Jun 10, 2016 at 04:07:17PM +0300, Roger Quadros wrote:
quoted hunk ↗ jump to hunk
index dca7856..03f7204 100644--- a/drivers/usb/Makefile +++ b/drivers/usb/Makefile@@ -59,5 +59,6 @@ obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ obj-$(CONFIG_USB_GADGET) += gadget/ obj-$(CONFIG_USB_COMMON) += common/ +obj-$(CONFIG_USB_OTG_CORE) += common/
I don't think you need to make above change, why you do it?
+ +/** + * usb_otg_get_data() - get usb_otg data structa
%s/structa/structure
+
+/**
+ * usb_otg_kick_fsm() - Kick the OTG state machine
+ * @otg_dev: OTG controller device
+ *
+ * Used by USB host/gadget stack to sync OTG related
+ * events to the OTG state machine.
+ * e.g. change in host_bus->b_hnp_enable, gadget->b_hnp_enable
+ *
+ * Return: 0 on success, error value otherwise.
+ */
+int usb_otg_kick_fsm(struct device *otg_dev)
+{
+ struct usb_otg *otg;
+
+ mutex_lock(&otg_list_mutex);
+ otg = usb_otg_get_data(otg_dev);
+ mutex_unlock(&otg_list_mutex);
+ if (!otg) {
+ dev_dbg(otg_dev, "otg: %s: invalid otg device\n",
+ __func__);
+ return -ENODEV;
+ }
+
+ usb_otg_sync_inputs(otg);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(usb_otg_kick_fsm);Do you have any users for this API? If no, please delete it in this version.
+ +/** + * usb_otg_register_hcd() - Register the host controller to OTG core + * @hcd: host controller + * @irqnum: interrupt number + * @irqflags: interrupt flags + * @ops: HCD ops to interface with the HCD + * + * This is used by the USB Host stack to register the host controller + * to the OTG core. Host controller must not be started by the + * caller as it is left upto the OTG state machine to do so.
%s/upto/up to
+ +/** + * usb_otg_register_gadget() - Register the gadget controller to OTG core + * @gadget: gadget controller instance + * @ops: gadget interface ops + * + * This is used by the USB gadget stack to register the gadget controller + * to the OTG core. Gadget controller must not be started by the + * caller as it is left upto the OTG state machine to do so. + *
%s/upto/up to -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html