Thread (27 messages) 27 messages, 5 authors, 2013-01-29
STALE4926d

Re: [PATCH 05/12] ARM: OMAP3xxx: PM: convert to use the functional power states API

From: Jean Pihet <hidden>
Date: 2012-12-12 10:18:23
Also in: linux-arm-kernel

Paul,

On Sun, Dec 9, 2012 at 6:53 PM, Paul Walmsley [off-list ref] wrote:
From: Jean Pihet <redacted>

Use the functional power states as the API to control power domains:

- use the PWRDM_FUNC_PWRST_* macros for the power states and logic
  settings,

- the function pwrdm_set_next_fpwrst(), which controls the power domains
  next power and logic settings, shall be used instead of
  pwrdm_set_next_pwrst() to program the power domains next states,

- the function pwrdm_set_fpwrst(), which programs the power domains
  power and logic settings, shall be used instead of
  omap_set_pwrdm_state().

Signed-off-by: Jean Pihet <redacted>
[paul@pwsan.com: split the original patch into OMAP2/3/4 variants;
 clean up omap3_save_secure_ram_context(); fix commit message;
 warn if sets fail; various other changes]
There are a lot of 'XXX' comments, can this be fixed by a proper comment?

Regards,
Jean

Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
 arch/arm/mach-omap2/cpuidle34xx.c |   95 ++++++++++++-----------
 arch/arm/mach-omap2/pm.h          |    2
 arch/arm/mach-omap2/pm34xx.c      |  156
+++++++++++++++++++------------------
 3 files changed, 130 insertions(+), 123 deletions(-)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help