Thread (17 messages) 17 messages, 5 authors, 2012-10-01

Re: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

From: Tony Lindgren <tony@atomide.com>
Date: 2012-09-28 15:05:38
Also in: linux-arm-kernel

* Shilimkar, Santosh [off-list ref] [120928 08:02]:
On Fri, Sep 28, 2012 at 8:25 PM, Tony Lindgren [off-list ref] wrote:
quoted
* Lokesh Vutla [off-list ref] [120928 06:41]:
quoted
Move plat/dma.h header to platform_data/dma-omap.h as
part of the single zImage work.
Hmm there's no platform data in this header, just
exported things for drivers to use. So it should not
be placed into platform_data.

Maybe it should be #include <asm/mach/dma-omap.h> for now?
I wasn't sure either when the file was placed under platform-data.
I agree for now we can keep it mach layer but than means OMAP1 and
OMAP2+ DMA header and source code needs to be split. That
is not so straight forward.
No need for that, the path I'm suggesting is located under
arch/arm/include/asm/mach, it's not same as include <mach/dma-omap.h>.
 
With DMA engine conversion hopefully, we might get rid of the
header eventually, but for now not sure whether we should
go ahead and follow the splitting part.

Thoughts ?
No need for splitting anything :)

The other possible location would be just include <linux/dma-omap.h>,
but as we all know that will be going away, <asm/mach/dma-omap.h>
is probably better.

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help