Re: [PATCH 1/6] OMAPDSS: DISPC: Remove cpu_is_xxxx checks
From: Tomi Valkeinen <hidden>
Date: 2012-08-07 09:05:29
Also in:
linux-fbdev
Attachments
- signature.asc [application/pgp-signature] 836 bytes
From: Tomi Valkeinen <hidden>
Date: 2012-08-07 09:05:29
Also in:
linux-fbdev
On Tue, 2012-08-07 at 11:48 +0300, Felipe Balbi wrote:
you're not really removing. You're moving cpu_is_* somewhere else. A better approach, IMHO, would be to use the DSS_REVISION register to differentiate the DSS IP itself, not the OMAP.
Unfortunately we can't, DSS_REVISION contains bogus information. I didn't look at these patches yet, but the idea has been to move the cpu_is_* checks to only a few central places, not scattered all over. At some point we could perhaps either move the cpu_is_ check code to somewhere under arch/arm, or, more probably, create our own DSS version IDs which are found out via cpu_is or soc_is or such. Tomi