Re: [PATCH 1/5] drivercore: add new error value for deferred probe

On Fri, Oct 07, 2011 at 07:28:33PM -0400, Valdis.Kletnieks@vt.edu wrote:

On Fri, 07 Oct 2011 16:12:45 MDT, Grant Likely said:

quoted

On Fri, Oct 7, 2011 at 12:43 AM, Greg KH [off-list ref] wrote:

quoted

On Fri, Oct 07, 2011 at 10:33:06AM +0500, G, Manjunath Kondaiah wrote:

quoted

quoted

quoted

+#define EPROBE_DEFER 517     /* restart probe again after some time */

Can we really do this?

quoted

According to Arnd, yes this is okay.

quoted

quoted

 Isn't this some user/kernel api here?

quoted

quoted

What's wrong with just "overloading" on top of an existing error code?
Surely one of the other 516 types could be used here, right?

quoted

overloading makes it really hard to find the users at a later date.

Would proposing '#define EPROBE_DEFER EAGAIN' be acceptable to everybody? That
would allow overloading EAGAIN, but still make it easy to tell the usages apart
if we need to separate them later...

Yes, please do that, it is what USB does for it's internal error code
handling.

greg k-h