Thread (38 messages) 38 messages, 8 authors, 2011-08-17

Re: [RFC PATCH 4/6] OMAP4: Temperature sensor device support

From: Tony Lindgren <tony@atomide.com>
Date: 2011-08-10 12:41:09

* Felipe Balbi [off-list ref] [110810 05:31]:
On Wed, Aug 10, 2011 at 05:55:20PM +0530, Keerthy wrote:
quoted
+
+int __init omap_devinit_temp_sensor(void)
+{
+	if (!cpu_is_omap446x())
+		return 0;
+
+	return omap_hwmod_for_each_by_class("temperature_sensor",
+			temp_sensor_dev_init, NULL);
+}
+
+arch_initcall(omap_devinit_temp_sensor);
I really dislike people adding more and more *initcall() to their pieces
of code. But Tony is the final Judge.
Yes how about making this just a regular device driver and have it
live under drivers/ somewhere?

Or is there some reason why this could not be a loadable module?

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help